Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getinfo: provide info which auth was used for HTTP and proxy #15450

Closed
wants to merge 2 commits into from
Closed

getinfo: provide info which auth was used for HTTP and proxy #15450

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 29, 2024 •
edited
Loading

CURLINFO_HTTPAUTH_USED and CURLINFO_PROXYAUTH_USED

Ref: #12668
Idea-by: Ganesh Viswanathan

  • initial implementation
  • document both options
  • make sure NTLM is reported on subsequent requests
  • properly tested
  • save exposing it in the curl tool for later

@bagder bagder added HTTP feature-window A merge of this requires an open feature window authentication libcurl API labels Oct 29, 2024
@github-actions github-actions bot added the tests label Oct 29, 2024
@dfandrich

This comment was marked as outdated.

Sign in to view
@bagder
getinfo: provide info which auth was used for HTTP and proxy
184531d 
CURLINFO_HTTPAUTH_USED and CURLINFO_PROXYAUTH_USED

Tested in 590

Ref: #12668
Idea-by: Ganesh Viswanathan
Closes #15450
@bagder
fixup add test 694 to verify repeated NTLM
b4673ae
@bagder bagder force-pushed the bagder/used-auth-info branch from c18470c to b4673ae Compare December 23, 2024 12:31
@bagder bagder marked this pull request as ready for review December 23, 2024 12:39
@bagder bagder closed this in 9d5ecc9 Dec 23, 2024
@bagder bagder deleted the bagder/used-auth-info branch December 23, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
authentication feature-window A merge of this requires an open feature window hacktoberfest-accepted HTTP libcurl API tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagder @dfandrich