Skip to content

HTTPS-Proxy: don't offer h2 for https proxy conn. draft1 #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HTTPS-Proxy: don't offer h2 for https proxy conn. draft1 #1546

wants to merge 1 commit into from

Conversation

@lon990109tim
Copy link

@lon990109tim lon990109tim commented Jun 6, 2017

Bug: #1254

@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage increased (+0.03%) to 73.186% when pulling 76e3034 on jay:disable_h2_for_https_proxy into de0adda on curl:master.

bagder
bagder approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, are you @jay ? I realize there's room for improvement to do this at the generic vtls level, but this is still better than what we have right now IMHO.

@bagder bagder closed this in 17c5d05 Jun 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
@jay jay deleted the disable_h2_for_https_proxy branch November 27, 2022 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

connecting & proxies HTTP/2 TLS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lon990109tim @coveralls @bagder @jay