unit1307: tidy up Apple OS detection - #15461
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
vszakats
changed the title
Contributor
|
Analysis of PR #15461 at d5a2802a: Test http/test_07_upload.py::TestUpload::test_07_22_upload_parallel_fail[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
bagder
approved these changes
Oct 31, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Use `__APPLE__` macro to detect Apple OS instead of relying on the string in `CURL_OS`. This also fixes detection with default CMake builds where `CURL_OS` is `Darwin`. The code before this patch was expecting this substring in lowercase. Closes curl#15461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
__APPLE__macro to detect Apple OS instead of relying onthe string in
CURL_OS.This also fixes detection with default CMake builds where
CURL_OSisDarwin. The code before this patch was expecting this substring inlowercase.