tests: use a set for several of the curl_props #15462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used for member-of testing, so a set is more appropriate and efficient. Also, fix a couple cases of bad exceptions. Closes #15462
|
Analysis of PR #15462 at 610fe738: Test 1193 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1917 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2202 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2205 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
|
Test comment |
|
Test comment 2 |
|
Test comment 3 |
|
Test comment 4 |
|
Test comment 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used for member-of testing, so a set is more appropriate and
efficient. Also, fix a couple cases of bad exceptions.
Closes #15462