winbuild: drop gen_resp_file.bat - #15463
Closed
vszakats wants to merge 4 commits into
Closed
Conversation
vszakats
marked this pull request as draft
October 31, 2024 09:18
vszakats
marked this pull request as ready for review
October 31, 2024 09:56
Contributor
|
Analysis of PR #15463 at 51bf96c1: Test 710 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 715 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 831 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`gen_resp_file.bat` could be reduced to 3 lines. Those lines are simple to use from `Makefile.vc` as-is. Also drop the unnecessary tabs. Closes curl#15463
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_resp_file.batcould be reduced to 3 lines.Those lines are simple to use from
Makefile.vcas-is.Also drop the unnecessary tabs.