Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winbuild: drop gen_resp_file.bat #15463

Closed
wants to merge 4 commits into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 31, 2024

gen_resp_file.bat could be reduced to 3 lines.
Those lines are simple to use from Makefile.vc as-is.

Also drop the unnecessary tabs.

@vszakats vszakats added build Windows Windows-specific tidy-up labels Oct 31, 2024
@vszakats vszakats marked this pull request as draft October 31, 2024 09:18
@vszakats vszakats changed the title gen_resp_file.bat: tidy up winbuild: drop gen_resp_file.bat Oct 31, 2024
@vszakats vszakats marked this pull request as ready for review October 31, 2024 09:56
@dfandrich
Copy link
Contributor

Analysis of PR #15463 at 51bf96c1:

Test 710 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 715 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 831 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants