cmake: make libpsl required by default #15464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in `./configure`: To force users to explictily disable it if they really don't want it used and make it harder to accidentally miss it. `-DCURL_USE_LIBPSL=OFF` is the option to use if PSL is not wanted. Follow-up to 2998874 curl#12661
vszakats
added
build
cmake
cookies
feature-window
|
In the last CI here, the CodeQL job could find libpsl: https://github.com/curl/curl/actions/runs/11610926878/job/32331214399 But no longer in the latest master: https://github.com/curl/curl/actions/runs/12359119167/job/34491305134 A CodeQL update or the Ubuntu 24.04 upgrade (from 22.04) may have caused this. |
vszakats
added a commit
that referenced
this pull request
Dec 16, 2024
Stay with the default CMake build. It requires libpsl now, but the latest Ubuntu runner no longer seems to provide it. Install it manually. Bug: #15464 (comment) Follow-up to 7afbc39 #15464 Closes #15760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done earlier in
./configure:To force users to explictily disable it if they really don't want it
used and make it harder to accidentally miss it.
-DCURL_USE_LIBPSL=OFFis the option to use if PSL is not wanted.Follow-up to 2998874 #12661