projects/Windows: remove wolfSSL from legacy projects #15468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #15468 at 3cbe771d: Test 503 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
reviewed
Nov 1, 2024
vszakats
approved these changes
Nov 1, 2024
jay
force-pushed
the
rm_wolfssl_from_projects
branch
from
6a4f286 to
9cc5fc1
Compare
jay
added a commit
to jay/curl
that referenced
this pull request
Nov 21, 2024
- Remove wolfSSL from the legacy projects for Visual Studio 2010 - 2013. It's no longer possible to maintain the custom build configuration of wolfSSL for these old versions of Visual Studio. Note support for wolfSSL was recently added to the winbuild build system in 4de627a and the user could possibly make their own wolfSSL build and attempt to link it using an old version of Visual Studio that way. Ref: https://gist.github.com/jay/5f6d8d5ba15c12c7457e3216a94da72d Closes curl#15468
MarcelRaad
approved these changes
Nov 21, 2024
vszakats
approved these changes
Nov 21, 2024
- Remove wolfSSL from the legacy projects for Visual Studio 2010 - 2013. It's no longer possible to maintain the custom build configuration of wolfSSL for these old versions of Visual Studio. Note support for wolfSSL was recently added to the winbuild build system in 4de627a and the user could possibly make their own wolfSSL build and attempt to link it using an old version of Visual Studio that way. Ref: https://gist.github.com/jay/5f6d8d5ba15c12c7457e3216a94da72d Closes curl#15468
jay
force-pushed
the
rm_wolfssl_from_projects
branch
from
9cc5fc1 to
7037046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer possible to maintain the custom build configuration of wolfSSL for these old versions of Visual Studio.
Note support for wolfSSL was recently added to the winbuild build system in 4de627a and the user could possibly make their own wolfSSL build and attempt to link it using an old version of Visual Studio that way.
Ref: https://gist.github.com/jay/5f6d8d5ba15c12c7457e3216a94da72d
Closes #xxxx