Skip to content

pytest: include curl version string and python platform in log - #15470

Closed
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:pytest-curl-ver
Closed

pytest: include curl version string and python platform in log#15470
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:pytest-curl-ver

Conversation

@vszakats

@vszakats vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member

@vszakats vszakats added the tests label Nov 1, 2024
@vszakats

vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

macOS jobs are broken since Homebrew upgraded to OpenSSL 3.4.0 (from 3.3.x) in the last ~10 hours.
It fails when generating certificates.

@icing

icing commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

macOS jobs are broken since Homebrew upgraded to OpenSSL 3.4.0 (from 3.3.x) in the last ~10 hours. It fails when generating certificates.

the build-cert steps fails for me locally on macOS also. My system openssl is 3.3.6.

Update: openssl 3.4 works fine, but the macOS system "openssl" is a libressl bastard that, for unknown reasons, wants to lookup a '.srl' file - whatever that is.

@dfandrich

Copy link
Copy Markdown
Contributor

Analysis of PR #15470 at 40b6898d:

Test 1452 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@icing

icing commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@vszakats : libressl (which is behind macOS openssl command) now requres a .srl file for a CA. If we add a file EdelCurlRoot-ca.srl that just contains a hexnumber line like:

34566D

it will work. It updates the file whenever it generates a certificate.

@vszakats

vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

@icing: Indeed, I'm trying the -CAcreateserial approach here: #15471

(what's unclear is why the fallout now. It seems LibreSSL always required that option, we always stripped the Homebrew OpenSSL from PATH and must have been using LibreSSL all along, and there was no OS update between these jobs. Hopefully the added openssl version log will help with this in the future.)

@dfandrich dfandrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing left missing on the features table is the host architecture, and we can get that with #15256. But maybe it's better to just add the equivalent to pytest_report_header() which means essentially just printing platform.platform(), or perhaps a more structured version.

@vszakats

vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

The only thing left missing on the features table is the host architecture, and we can get that with #15256. But maybe it's better to just add the equivalent to pytest_report_header() which means essentially just printing platform.platform(), or perhaps a more structured version.

platform.platform() sounds good, but there is buildinfo.host.cpu, is there an issue with it?

@dfandrich

dfandrich commented Nov 1, 2024 via email

Copy link
Copy Markdown
Contributor

@vszakats

vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Ah ok, I didn't know. We could try to emulate what CMake is doing, but platform.platform() will no doubt be simpler. Making an attempt in this PR.

@vszakats vszakats changed the title pytest: include curl version string in log pytest: include curl version string and python platform in log Nov 1, 2024
@vszakats

vszakats commented Nov 1, 2024

Copy link
Copy Markdown
Member Author
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-8.3.3, pluggy-1.5.0 -- /usr/bin/python3
cachedir: .pytest_cache
Testing curl 8.11.0-DEV
  platform: Linux-6.8.0-1015-azure-x86_64-with-glibc2.39
  curl: Version: curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV BearSSL zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 nghttp2/1.59.0 OpenLDAP/2.6.7
[...]

@vszakats

vszakats commented Nov 2, 2024

Copy link
Copy Markdown
Member Author

Merged via 2502541. (GH missed running triggers on push?)

@vszakats vszakats closed this Nov 2, 2024
@vszakats
vszakats deleted the pytest-curl-ver branch November 2, 2024 01:04
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants