cmake: namespace functions and macros #15498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cm-namespace-functions
branch
3 times, most recently
from
c0a394f to
d28259c
Compare
vszakats
force-pushed
the
cm-namespace-functions
branch
from
3e54c88 to
324327b
Compare
talregev
reviewed
Dec 17, 2024
| @@ -27,7 +27,7 @@ | |||
| # This macro is intended to be called multiple times with a sequence of | |||
| # possibly dependent header files. Some headers depend on others to be | |||
| # compiled correctly. | |||
| macro(check_include_file_concat _file _variable) | |||
| macro(check_include_file_concat_curl _file _variable) | |||
There was a problem hiding this comment.
Can you change it to curl prefix instead suffix to align with the other names, and be more clear that is curl macro?
There was a problem hiding this comment.
It's a local variation of a built-in function. A prefix made this much less obvious and reduced readability. Hence the suffix for this particular name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix (or suffix) curl-defined macro and function names with
curl.To avoid collisions with non-curl CMake and to make them recognizable
as curl-specific calls.