Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECH: enable support for the AWS-LC backend #15499

Closed
wants to merge 7 commits into from
Closed

ECH: enable support for the AWS-LC backend #15499

wants to merge 7 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Nov 6, 2024 •
edited
Loading

Extend existing ECH support for BoringSSL to its AWS-LC fork.

Also enable ECH in AWS-LC CI jobs.

curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV AWS-LC/1.37.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc AsynchDNS brotli ECH HSTS HTTPS-proxy IPv6 Largefile libz NTLM PSL SSL threadsafe UnixSockets zstd

@vszakats vszakats added the CI Continuous Integration label Nov 6, 2024
@vszakats vszakats marked this pull request as draft November 6, 2024 15:38
@vszakats vszakats closed this Nov 6, 2024
@vszakats vszakats reopened this Nov 6, 2024
@vszakats vszakats changed the title GHA/linux: enable ECH in AWS-LC builds ech: add support for AWS-LC builds Nov 6, 2024
@vszakats vszakats changed the title ech: add support for AWS-LC builds ECH: add support for AWS-LC builds Nov 6, 2024
@vszakats vszakats added the build label Nov 6, 2024
@vszakats vszakats changed the title ECH: add support for AWS-LC builds ECH: add support for AWS-LC backend Nov 6, 2024
@vszakats vszakats marked this pull request as ready for review November 6, 2024 16:04
@vszakats vszakats added the TLS label Nov 6, 2024
@vszakats vszakats changed the title ECH: add support for AWS-LC backend ECH: add support for the AWS-LC backend Nov 6, 2024
@vszakats vszakats changed the title ECH: add support for the AWS-LC backend ECH: enable support for the AWS-LC backend Nov 8, 2024
@vszakats
Copy link
Member Author

vszakats commented Nov 8, 2024

Any objection to merge this now for the patch release?

I consider this a bugfix, as it just extends existing BoringSSL ECH support
to its fork AWS-LC. There is no new code involved, only extending existing
BoringSSL guards to AWS-LC.

@bagder
Copy link
Member

bagder commented Nov 8, 2024

No objection from me. I think it can land.

@vszakats vszakats closed this in 1cd745a Nov 8, 2024
@vszakats vszakats deleted the gha-linux-ech branch November 8, 2024 13:00
vszakats added a commit to curl/curl-for-win that referenced this pull request Nov 8, 2024
@vszakats
curl.test.patch: apply two upstream patches, enable ECH with AWS-LC […
ceb0779 
…ci skip]

Enable ECH with AWS-LC in test and dev builds.

- ECH: enable support for the AWS-LC backend
  curl/curl@1cd745a
  curl/curl#15499

- macos: disable gcc availability workaround as needed
  curl/curl@354f3f9
  curl/curl#15508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build CI Continuous Integration TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vszakats @bagder