cmake: drop cmake args list from buildinfo.txt
#15501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has the side-effect of silencing CMake warnings about unused variables passed via the command-line. Drop it till a better method is found to retrieve this. Reported-by: Kai Pastor Ref: curl#14936 (comment) Follow-up to 1fdea16 curl#14802
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Nov 13, 2024
This feature was recently dropped because of a bad side-effect of silencing unused cmake command-line warnings. Fix this issue by retrieving variable values using `get_property()`, instead of accessing the variables directly. It allows restoring this feature without the bad side-effect. Follow-up to 96edb5f curl#15501
vszakats
added a commit
that referenced
this pull request
Nov 14, 2024
This feature was recently dropped because of a bad side-effect of silencing unused cmake command-line option warnings. Fix this issue by retrieving variable values using `get_property()`, instead of accessing the variables directly. It allows restoring this feature without the bad side-effect. Also limit the logic to CI runs. Follow-up to 96edb5f #15501 Closes #15563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting the args list has the undesired side-effect of silencing
CMake warnings about unused variables passed via the command-line.
Drop it till a better method is found to retrieve them.
Reported-by: Kai Pastor
Ref: #14936 (comment)
Follow-up to 1fdea16 #14802