curl: --test-duphandle in debug builds runs "duphandled" #15504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/test-duphandle
branch
2 times, most recently
from
1a235c0 to
53dff3a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bagder
force-pushed
the
bagder/test-duphandle
branch
from
53dff3a to
5105c9d
Compare
Using this option only available in debug builds makes curl always call curl_easy_duphandle() on the handle before using it. This should help us catch curl_easy_duphandle() mistakes better. Add a CI job using this. Bonus: the previous runtests option -e is now also supported as --test-event
and add documentation
... since we also disable the tests for that
bagder
force-pushed
the
bagder/test-duphandle
branch
from
7aed621 to
569378e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this option only available in debug builds makes curl always call curl_easy_duphandle() on the handle before using it.
This should help us catch curl_easy_duphandle() mistakes better.
Add a CI job using this.
Bonus: the previous runtests option -e is now also supported as --test-event