The pthread linker flag already contains "-l"

[bjori]

The pkgconfig created by cmake adds "-l" to the pthread linked flag, producing -l-lpthread.
This comes from ${CURL_LIBS} which retrieves the ${CMAKE_THREAD_LIBS_INIT} value which already contains -l

This is reproducable on Ubuntu like so:

$ rm -rf cbuild && mkdir cbuild && cd cbuild && cmake .. -DENABLE_THREADED_RESOLVER=1 && cat *.pc

Before:

Libs.private:  -lc -ldl -l-lpthread /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so /usr/lib/x86_64-linux-gnu/libz.so

After:

Libs.private:  -lc -ldl -lpthread /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so /usr/lib/x86_64-linux-gnu/libz.so

Note that with ./configure --enable-threaded-resolver pthread isn't added to the .pc at all, as it is instead added to the CFLAGS as -pthread rather then linker flags as -lpthread

[coveralls]

Coverage decreased (-0.01%) to 73.213% when pulling 44f6906 on bjori:master into f7ee701 on curl:master.

[bagder]

Yes indeed, -lpthread is not added there by configure. I suppose that tells us a little how rarely that data is actually used, since I believe most linux distros ship with threaded-resolver enabled libcurls these days...

[bagder]

ping @Lekensteyn, this changes code you brought!

[bagder]

No response from any cmake hackers. It seems fine to me so I'll go ahead and merge anyway.

[bagder]

Thanks!