Makefile.mk: drop in favour of autotools and cmake (MS-DOS, AmigaOS3)

[vszakats]

Makefile.mk supported MS-DOS and Amiga, but ./configure also
supported them in a better tested and more flexible way.

This patch also adds CMake support for MS-DOS/DJGPP and Amiga OS 3.

Makefile.mk was not maintained. Delete it in favour of first-tier
build methods.

Also include some non-MS-DOS/AmigaOS-specific tidy-up, see details at
the end of this message.

Details:

• fix/silence all MS-DOS/DJGPP build warnings and issues.
• add MS-DOS support to cmake.
  • default to ENABLE_THREADED_RESOLVER=OFF for MS-DOS.
  • add support for WATT_ROOT.
  • use static libcurl with MS-DOS.
  • fixup default CMake suffixes/prefixes for DJGPP.
  • disable hidden symbols for MS-DOS. Not supported on MS-DOS.
  • opt-in MS-DOS into USE_UNIX_SOCKETS.
• improve MS-DOS support in autotools.
  • default to --disable-threaded-resolver for MS-DOS.
• make sure to use close_s() (from Watt-32) with autotools and cmake.
  Makefile.mk used it before this patch.
• GHA: add DJGPP cmake (~30s) and autotools (~60s) build jobs.
  Also build tests and examples with cmake.
• improve AmigaOS support in autotools:
  • configure: detect CloseSocket() when it's a macro.
  • configure: fix IoctlSocket detection on AmigaOS.
  • curl-amissl.m4: pass AmiSSL libs to tests/servers.
• add AmigaOS3 support to cmake:
  • cmake: fix HAVE_IOCTLSOCKET_CAMEL and
    HAVE_IOCTLSOCKET_CAMEL_FIONBIO detections.
  • set necessary system libs.
  • add AmiSSL support.
  • inet_ntop, inet_pton: fix using it for AmigaOS. cmake detects them,
    and they did not compile with AmigaOS.
  • cmake: better sync gethostname detection with autotools.
    Fixes detection for AmigaOS, where gethostname is a macro.
  • cmake: fix sys/utime.h detection on AmigaOS.
  • cmake: force-disable getaddrinfo for AmigaOS.
  • cmake: tweak threading and static/shared default for AmigaOS.
  • cmake: rely on manual variable AMIGA to enable the platform.
• GHA: add AmigaOS cmake and autotools (~45s) jobs.
  Also build tests and examples with cmake.
• INSTALL: update MS-DOS and AmigaOS build instructions.
• amigaos: fix -Wpointer-sign and
  zero or negative size array '_args' in Printf().
• amigaos: fix -Wpointer-sign
• amigaos: fix -Wredundant-decls errno and h_errno.
• amigaos: brute-force silence lseek() size warnings.
• amigaos: server/resolve: silence -Wdiscarded-qualifiers.
• amigaos: server/resolve: fix -Wpointer-sign.
• amigaos: fix CURL_SA_FAMILY_T type.
• nonblock: prefer HAVE_IOCTLSOCKET_CAMEL_FIONBIO for AmigaOS.
  ioctl is also detected, but fails when used. Make the above override
  it for a successful build.
  Authored-by: Darren Banfi
  Fixes Cross Compiling for Amiga OS - Error implicit declaration of function 'ioctl' #15537
  Closes Crosscompile for AmigaOS3 - Changes to Configure.ac and Nonblock.c #15603
• tftpd: prefer HAVE_IOCTLSOCKET_CAMEL_FIONBIO for AmigaOS.
• tftpd: tidy-up conditional code.
• curl: set stack size to 16384 for AmigaOS3/4
  Overriding the default 4096.
  Suggested-by: Darren Banfi
  Ref: Makefile.mk: drop in favour of autotools and cmake (MS-DOS, AmigaOS3) #15543 (comment)
  Ref: https://wiki.amigaos.net/wiki/Controlling_Application_Stack
• functypes.h: fix SEND_QUAL_ARG2 for AmigaOS.
• tftp: add missing cast in sendto() call for AmigaOS.
• getinfo: fix warning with AmigaOS.
• tool_operate: silence warning with AmigaOS
• amigaos: fix building libtests due to missing RLIMIT_NOFILE.
• curl_gethostname: silence warning for AmigaOS.
• ftp: silence -Wtype-limits for AmigaOS.
• libtest: fix timeval initialization for AmigaOS.
• examples: fix timeval initialization for AmigaOS.
• examples: silence warning for AmigaOS.
• configure: fix IPv6 detection for cross-builds.
• netrc: fix to build with AmigaOS cleanly.
• buildinfo: detect and add DOS tag for MS-DOS builds.
• buildinfo: add AMIGA to buildinfo.txt in auttools.
• build: move USE_WATT32 macro definition to cmake/configure.

Non-MS-DOS/AmigeOS-specific tidy-ups:

• configure: sync sa_family_t detection with cmake.
• configure: sync ADDRESS_FAMILY detection signals with cmake.
• doh: use CURL_SA_FAMILY_T.
• lib: drop mingw-specific CURL_SA_FAMILY_T workaround.
• cmake: extend instead of override check-specific
  configurations/requirements.
  This allows to honor global requirements added earlier.
  Necessary for AmigaOS for example.
• cmake: omit warning on disabled IPv6 for MS-DOS and AmigaOS.
  No IPv6 support on these platforms. Also sync with autotools.
• lib1960: use libcurl inet_pton() wrapper.
• cmake: detect LibreSSL (to match autotools).
• cmake: say the specific OpenSSL flavour detected.
• hostip: add missing HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID guard.
• lib: simplify classic mac feature guards.

Follow-up to a8861b6 #9764

---

• split into multiple PRs or commits? [MERGE AS-IS]

w/o whitespace: https://github.com/curl/curl/pull/15543/files?w=1

[vszakats]

Successfully cross-built for MS-DOS with:

DJGPP=/path/to/djgpp
./configure \
  CC="$DJGPP/bin/i586-pc-msdosdjgpp-gcc" \
  AR="$DJGPP/bin/i586-pc-msdosdjgpp-ar" \
  RANLIB="$DJGPP/bin/i586-pc-msdosdjgpp-ranlib" \
  WATT_ROOT="$DJGPP/net/watt" \
  --host=i586-pc-msdosdjgpp \
  --with-openssl="$DJGPP" \
  --with-zlib="$DJGPP" \
  --without-libpsl \
  --disable-shared

cmake . \
  -DCMAKE_SYSTEM_NAME=DOS \
  -DCMAKE_SYSTEM_PROCESSOR=x86 \
  -DCMAKE_C_COMPILER_TARGET=i586-pc-msdosdjgpp \
  -DCMAKE_C_COMPILER="$DJGPP/bin/i586-pc-msdosdjgpp-gcc" \
  -DWATT_ROOT="$DJGPP/net/watt" \
  -DOPENSSL_INCLUDE_DIR="$DJGPP/include" \
  -DOPENSSL_SSL_LIBRARY="$DJGPP/lib/libssl.a" \
  -DOPENSSL_CRYPTO_LIBRARY="$DJGPP/lib/libcrypto.a" \
  -DZLIB_INCLUDE_DIR="$DJGPP/include" \
  -DZLIB_LIBRARY="$DJGPP/lib/libz.a" \
  -DCURL_USE_LIBPSL=OFF

curl 8.11.1-DEV (i586-pc-msdosdjgpp) libcurl/8.11.1-DEV OpenSSL/1.0.2u zlib/1.2.12
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc HSTS HTTPS-proxy libz NTLM SSL threadsafe UnixSockets

build templates for Amiga:

# https://github.com/bebbo/amiga-gcc/releases/download/Mechen/amiga-gcc.tgz
# https://github.com/jens-maus/amissl/releases/download/5.18/AmiSSL-5.18-SDK.lha
AMISSL='/path/to/AmiSSL/Developer'
./configure \
  CC=/opt/appveyor/build-agent/opt/amiga/bin/m68k-amigaos-gcc \
  AR=/opt/appveyor/build-agent/opt/amiga/bin/m68k-amigaos-ar \
  RANLIB=/opt/appveyor/build-agent/opt/amiga/bin/m68k-amigaos-ranlib \
  --host=m68k-amigaos \
  --with-amissl \
  CFLAGS='-O0 -msoft-float -mcrt=clib2' \
  CPPFLAGS="-I$AMISSL/include" \
  LDFLAGS="-L$AMISSL/lib/AmigaOS3" \
  LIBS='-lnet -lm -latomic' \
  --without-libpsl \
  --disable-shared

cmake . \
  -DAMIGA=1 \
  -DCMAKE_SYSTEM_NAME=Generic \
  -DCMAKE_C_COMPILER_TARGET=m68k-unknown-amigaos \
  -DCMAKE_C_COMPILER=/opt/appveyor/build-agent/opt/amiga/bin/m68k-amigaos-gcc \
  -DCMAKE_C_FLAGS='-O0 -msoft-float -mcrt=clib2' \
  -DAMISSL_INCLUDE_DIR="$AMISSL/include" \
  -DAMISSL_STUBS_LIBRARY="$AMISSL/lib/AmigaOS3/libamisslstubs.a" \
  -DAMISSL_AUTO_LIBRARY="$AMISSL/lib/AmigaOS3/libamisslauto.a" \
  -DCURL_USE_LIBPSL=OFF

based on #15603

Officially there is no CMake support for DJGPP, but it works with some tweaks.
No support for Amiga OS at all, but could be made work.
Probably could be made to work with AmigaOS as well, but without cross-tool
binaries for my platforms, it's something for another time.

[vszakats]

I'm wondering if it'd make sense to delete lib/config-dos.h and lib/config-amigaos.h with this? They are no longer used within the repo. Or maybe convert them to configure caches?

edit: converting them to a cmake or autotools cache is certainly possible, but the maintenance cost is high.

[bagder]

I'm wondering if it'd make sense to delete lib/config-dos.h and lib/config-amigaos.h with this? They are no longer used within the repo. Or maybe convert them to configure caches?

edit: converting them to a cmake or autotools cache is certainly possible, but the maintenance cost is high.

I think trying to do them as caches is just overkill and not something we do for any other platforms either. configure/cmake should be able to generate the correct setup on their own. IMHO, those two "hard coded" config files should be removed if we think configure/cmake can do the job.

[vszakats]

Arrived to the same conclusion, it's overkill.

With MS-DOS + CMake the toolchain env is detected fine now (also matching previous manual values). Dependency detection is probably broken due to CMake insisting on the .lib suffix, but feeding the libs manually via -DNAME_LIBRARY=/path/to/libname.a should work it around.