Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl-rustls.m4: keep existing CPPFLAGS/LDFLAGS when detected #15546

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

Different variable names were used in flag save and restore operations,
which could cause existing CPPFLAGS and LDFLAGS be accidentally lost
when detecting Rustls.

Follow-up to 647e86a #13179

Different variable names were used in flag save and restore operations,
which could cause existing `CPPFLAGS` and `LDFLAGS` be accidentally lost
when detecting Rustls.

Follow-up to 647e86a curl#13179
@vszakats vszakats added the build label Nov 11, 2024
@github-actions github-actions bot added the TLS label Nov 11, 2024
@vszakats vszakats changed the title configure: keep existing CPPFLAGS/LDFLAGS when Rustls is detected curl-rustls.m4: keep existing CPPFLAGS/LDFLAGS when detected Nov 11, 2024
@vszakats vszakats closed this in 774844a Nov 11, 2024
@vszakats vszakats deleted the am-rustls-flags branch November 11, 2024 13:32
talregev pushed a commit to talregev/curl that referenced this pull request Nov 13, 2024
Different variable names were used in flag save and restore operations,
which could cause existing `CPPFLAGS` and `LDFLAGS` be accidentally lost
when detecting Rustls.

Follow-up to 647e86a curl#13179
Closes curl#15546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant