Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs/examples/multi-uv.c deprecated symbol #1557

wants to merge 1 commit into from


Copy link

@rkmathi rkmathi commented Jun 8, 2017

I found one of libuv's symbol is outdated in docs/examples/multi-uv.

When I compile this example, I get a warning such as:

$ gcc -I../../include -I../../out/include/curl -I../../../../libuv/libuv/out/include multi-uv.c
multi-uv.c: In function ‘start_timeout’:        
multi-uv.c:168:30: warning: passing argument 2 of ‘uv_timer_start’ from incompatible pointer type [-Wincompatible-pointer-types]
     uv_timer_start(&timeout, on_timeout, timeout_ms, 0);           
In file included from multi-uv.c:37:0:                              
../../../../libuv/libuv/out/include/uv.h:785:15: note: expected ‘uv_timer_cb {aka void (*)(struct uv_timer_s *)}’ but argument is of type ‘void (*)(uv_timer_t *, int) {aka void (*)(struct uv_timer_s *, int)}’
 UV_EXTERN int uv_timer_start(uv_timer_t* handle,

I checked libuv/libuv repository and found symbol void (*uv_timer_cb)(uv_timer_t* handle, int status); is outdated.
(diff: libuv/libuv@db2a907#diff-56343bd7ad8bf449c2693082fb3e4081L408 )

Copy link

Coverage Status

Coverage decreased (-0.04%) to 73.217% when pulling 520492c on rkmathi:fix-uv-example into 6c59074 on curl:master.

@bagder bagder closed this in bc164de Jun 8, 2017
Copy link

bagder commented Jun 8, 2017


@rkmathi rkmathi deleted the fix-uv-example branch September 22, 2017 05:47
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants