Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krb5: fix socket confusion, MSVC compiler warnings #15585

Closed
wants to merge 4 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Nov 15, 2024


@github-actions github-actions bot added the CI Continuous Integration label Nov 15, 2024
@talregev
Copy link
Contributor

Thank you for your fix! 🎉
I drop my PR in favor this PR.

@vszakats vszakats changed the title krb5: fix socket/sockindex confusion krb5: fix socket/sockindex confusion and compiler warnings Nov 15, 2024
@vszakats vszakats changed the title krb5: fix socket/sockindex confusion and compiler warnings krb5: fix socket confusion, compiler warnings, add to Windows CI Nov 15, 2024
@vszakats vszakats added the FTP label Nov 15, 2024
vszakats and others added 4 commits November 15, 2024 23:03
```
D:\a\curl\curl\lib\krb5.c(288,1): warning C4701: potentially uninitialized local variable '_gssresp' used
```
https://github.com/curl/curl/actions/runs/11848626645/job/33020501026?pr=15585#step:9:31
Add gssapi to openssl job

waiting for:
- [x] curl#15564
- [x] curl#15545

Closes curl#15549
@vszakats vszakats changed the title krb5: fix socket confusion, compiler warnings, add to Windows CI krb5: fix socket confusion, MSVC compiler warnings Nov 15, 2024
@testclutch
Copy link

Analysis of PR #15585 at 7a430ccc:

Test 3028 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@vszakats vszakats removed the CI Continuous Integration label Nov 15, 2024
@vszakats vszakats closed this in c41e9cc Nov 15, 2024
vszakats pushed a commit that referenced this pull request Nov 15, 2024
@vszakats vszakats deleted the krb5-fix branch November 15, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

int/socket confusion warnings
3 participants