cmake: do not echo most inherited LDFLAGS to config files
#15617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
String to list conversion based on existing logic in `CMake/FindGSS.cmake`.
vszakats
force-pushed
the
cm-pc-ldflags
branch
from
c32883e to
027a3a3
Compare
Member
Author
|
@diizzyy Does this fix your case? |
Contributor
|
Yes indeed, works well on my end. Thanks! |
vszakats
changed the title
LDFLAGS to config files
Member
Author
|
@diizzyy Thanks for testing! This is merged now. |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Sync with autotools and filter out most linker flags inherited via `CMAKE_SHARED_LINKER_FLAGS` (that includes `LDFLAGS` env) before echoing them in `libcurl.pc` `Libs.private` and `curl-config` `--static-libs`. Keep inheriting `-l`, `-L`, `-F`, `--library-path=`, `-framework` options. Follow-up to e244d50 curl#15550 Follow-up to 9f56bb6 curl#14681 Follow-up to 8ed66f9 Closes curl#15617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with autotools and filter out most linker flags inherited via
CMAKE_SHARED_LINKER_FLAGS(that includesLDFLAGSenv) beforeechoing them in
libcurl.pcLibs.privateandcurl-config--static-libs.Keep inheriting
-l,-L,-F,--library-path=,-frameworkoptions.
Follow-up to e244d50 #15550
Follow-up to 9f56bb6 #14681
Follow-up to 8ed66f9