tool_getpass: restore UWP getpass_r(), fixup CI builds, fix UWP -Wnull-dereference
#15638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advantage over `getch()` that it's not officially deprecated. https://learn.microsoft.com/cpp/c-runtime-library/reference/getch-getwch https://learn.microsoft.com/cpp/c-runtime-library/reference/getch Follow-up to f988842 curl#15637
vszakats
force-pushed
the
w-getch-more
branch
from
1baa669 to
35fedf1
Compare
```
D:/a/curl/curl/lib/vtls/schannel_verify.c: In function 'Curl_verify_host':
D:/a/curl/curl/lib/vtls/schannel_verify.c:558:33: error: null pointer dereference [-Werror=null-dereference]
558 | for(i = 0; i < alt_name_info->cAltEntry; ++i) {
| ~~~~~~~~~~~~~^~~~~~~~~~~
D:/a/curl/curl/lib/vtls/schannel_verify.c:559:50: error: null pointer dereference [-Werror=null-dereference]
559 | PCERT_ALT_NAME_ENTRY entry = &alt_name_info->rgAltEntry[i];
| ~~~~~~~~~~~~~^~~~~~~~~~~~
```
https://github.com/curl/curl/actions/runs/12022656065/job/33515255397?pr=15638#step:19:27
vszakats
force-pushed
the
w-getch-more
branch
from
35fedf1 to
1f52274
Compare
This reverts commit cb6380f.
This reverts commit f41248c. OK, the mingw jobs is compiled as UWP.
no longer used.
vszakats
changed the title
getpass_r() for UWP, fixup CI builds
vszakats
changed the title
getpass_r() for UWP, fixup CI buildsgetpass_r() for UWP, fixup CI builds
vszakats
changed the title
getpass_r() for UWP, fixup CI buildsgetpass_r() for UWP, fixup CI builds, fix UWP -Wnull-dereference
vszakats
changed the title
getpass_r() for UWP, fixup CI builds, fix UWP -Wnull-dereferencegetpass_r(), fixup CI builds, fix UWP -Wnull-dereference
vszakats
changed the title
getpass_r(), fixup CI builds, fix UWP -Wnull-dereferencegetpass_r(), fixup CI builds, fix schannel -Wnull-dereference
vszakats
changed the title
getpass_r(), fixup CI builds, fix schannel -Wnull-dereferencegetpass_r(), fixup CI builds, fix UWP -Wnull-dereference
vszakats
added a commit
that referenced
this pull request
Nov 27, 2024
`getch()` is deprecated according to MSDN: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch "The Microsoft-specific function name `getch` is a deprecated alias for the `_getch` function." Ref: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch-getwch Follow-up to 72edb22 #15638 Closes #15642
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…null-dereference` - GHA/windows: switch mingw-w64 UWP CI job to use UCRT. `msvcr120_app` was missing `getch()` for example. Follow-up to f988842 curl#15637 This job tests compiling for UWP correctly, but the the resulting `curl.exe` still doesn't look like a correct UWP app, now exiting on startup with: `curl: error initializing curl library`. - tool_getpass: restore `getch()` for UWP builds. Follow-up to f988842 curl#15637 - schannel: silence `-Werror=null-dereference` warning in mingw-w64 UWP: ``` lib/vtls/schannel_verify.c: In function 'Curl_verify_host': lib/vtls/schannel_verify.c:558:33: error: null pointer dereference [-Werror=null-dereference] 558 | for(i = 0; i < alt_name_info->cAltEntry; ++i) { | ~~~~~~~~~~~~~^~~~~~~~~~~ lib/vtls/schannel_verify.c:559:50: error: null pointer dereference [-Werror=null-dereference] 559 | PCERT_ALT_NAME_ENTRY entry = &alt_name_info->rgAltEntry[i]; | ~~~~~~~~~~~~~^~~~~~~~~~~~ ``` Ref: https://github.com/curl/curl/actions/runs/12022656065/job/33515255397?pr=15638#step:19:27 Follow-up to 9640a8e curl#15421 - GHA/windows: fix `find` command in MSVC job step. Follow-up to 5f9411f curl#15380 - GHA/windows: drop unnecessary `windowsappcompat` lib from mingw-w64 UWP job. Also drop related MSYS2 package. - GHA/windows: cmake 3.31.0 still invokes `windres` with wrong options with mingw-w64 UPW. Update curl version in comment accordingly. - GHA/windows: tidy up mingw-w64 UWP spec logic, limit it to gcc. - GHA/windows: update comments on `curl.exe` UWP startup errors. Closes curl#15638
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`getch()` is deprecated according to MSDN: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch "The Microsoft-specific function name `getch` is a deprecated alias for the `_getch` function." Ref: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch-getwch Follow-up to 72edb22 curl#15638 Closes curl#15642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA/windows: switch mingw-w64 UWP CI job to use UCRT.
msvcr120_appwas missinggetch()for example.Follow-up to f988842 tool_getpass: make local
getpass_r()a dummy for UWP #15637This job tests compiling for UWP correctly, but the the resulting
curl.exestill doesn't look like a correct UWP app, now exitingon startup with:
curl: error initializing curl library.tool_getpass: restore
getch()for UWP builds.Follow-up to f988842 tool_getpass: make local
getpass_r()a dummy for UWP #15637schannel: silence
-Werror=null-dereferencewarning in mingw-w64 UWP:Ref: https://github.com/curl/curl/actions/runs/12022656065/job/33515255397?pr=15638#step:19:27
Follow-up to 9640a8e fix schannel tls cert verification by IP SAN #15421
GHA/windows: fix
findcommand in MSVC job step.Follow-up to 5f9411f GHA/windows: work around Git for Windows perf regression #15380
GHA/windows: drop unnecessary
windowsappcompatlib from mingw-w64UWP job. Also drop related MSYS2 package.
GHA/windows: cmake 3.31.0 still invokes
windreswith wrong optionswith mingw-w64 UPW. Update curl version in comment accordingly.
GHA/windows: tidy up mingw-w64 UWP spec logic, limit it to gcc.
GHA/windows: update comments on
curl.exeUWP startup errors.w/o whitespace: https://github.com/curl/curl/pull/15638/files?w=1
getch()to_getch()on Windows. → tool_getpass: replacegetch()call with_getch()on Windows #15642