tool_getpass: replace getch() call with _getch() on Windows
#15642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vszakats
changed the title
_getch() on Windowsgetch() with _getch() on Windows
vszakats
changed the title
getch() with _getch() on Windowsgetch() with _getch() on Windows
vszakats
changed the title
getch() with _getch() on Windowsgetch() call with _getch() on Windows
MarcelRaad
approved these changes
Nov 26, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`getch()` is deprecated according to MSDN: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch "The Microsoft-specific function name `getch` is a deprecated alias for the `_getch` function." Ref: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch-getwch Follow-up to 72edb22 curl#15638 Closes curl#15642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getch()is deprecated according to MSDN:https://learn.microsoft.com/cpp/c-runtime-library/reference/getch
"The Microsoft-specific function name
getchis a deprecated aliasfor the
_getchfunction."Ref: https://learn.microsoft.com/cpp/c-runtime-library/reference/getch-getwch
Follow-up to 72edb22 #15638