-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: re-enable 2086, and 472, 1299, 1613 for Windows #15644
Conversation
They are failing on Linux/macOS/Windows, 1801 consistently, 1184 a bit less consistently.
92b17d5
to
bf57336
Compare
Ah, test 2086 [Pre-request callback for HTTP IPv6] still fails for me:
Looks like we have to tell MSYS2 to leave what it recognizes as path separators alone. |
Isn't this a function of MSYS2 version? Its changelog says something changed around here recently: If so, I still have no idea how to detect this and force it to work for older MSYS2 versions. |
I think we just need to set |
Are you also using the freshest MSYS2? edit: based on That envvar is suspect indeed, though I had very little experience/success with it, We can certainly put it back to the DISABLE list if there is no obvious solution. edit: a milder solution is to ignore this test via TFLAGS in the failing envs. |
Yes, it's indeed an older version - I'm a bit hesitant to update it as updates regularly break the e-mail client. I can confirm that setting |
Older MSYS2 versions treat the URL as paths list and convert them from UNIX to Windows format. There's no path here that needs to be converted, so disable path conversion for this test as done for others. Fixes curl#15644 (comment) Closes curl#15677
Older MSYS2 versions treat the URL as paths list and convert them from UNIX to Windows format. There's no path here that needs to be converted, so disable path conversion for this test as done for others. Fixes curl#15644 (comment) Closes curl#15677
GHA/windows: un-ignore tests 472 1299 1613.
They were ignored for the mingw-w64 c-ares U job.
They do run fine now:
https://github.com/curl/curl/actions/runs/12032875421/job/33547724780?pr=15644
globally re-enable test 2086.
Comment says it only affected Windows.
Seems to be running fine now. Example:
Windows:
https://github.com/curl/curl/actions/runs/12032875421/job/33547718309?pr=15644#step:13:3856
Linux:
https://github.com/curl/curl/actions/runs/12032875397/job/33545739712#step:41:3650
update comments for disabled tests 1184, 1801.
They affect all operating systems, likely all CIs.
FAIL 1801: 'HTTP/2 upgrade with lying server' HTTP, HTTP/2
https://github.com/curl/curl/actions/runs/12032362497/job/33544053001#step:14:4265
FAIL 1184: 'HTTP 1.1 CONNECT with redirect and set -H user-agent' HTTP, HTTP CONNECT, HTTP proxy, proxytunnel
https://github.com/curl/curl/actions/runs/12032362497/job/33544051415#step:14:5252