20241126-wolf-opensslcoexist-expansion #15650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
reviewed
Nov 26, 2024
|
Analysis of PR #15650 at 4bf1aa14: Test 1049 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
3 tasks
…cludes contribs from @vszakats.
douzzer
force-pushed
the
20241126-wolf-opensslcoexist-expansion
branch
from
4bf1aa1 to
f734367
Compare
|
@vszakats PR is updated with your patches. The wolfssl |
vszakats
approved these changes
Dec 3, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for wolfSSL
OPENSSL_COEXISTexpansion for MD4, MD5, and DES.The wolf-native APIs and types used in the changes are all old/preexisting -- there wasn't any need for version gating on any of this.
Tested with
wolfssl-multi-test.sh ... curl-master-with-wolfssl-coexistwolfSSL:
./configure --enable-curl --enable-opensslcoexist --prefix="/tmp/installed-for-curl" CFLAGS=-DTEST_OPENSSL_COEXISTcurl:
./configure --with-wolfssl="/tmp/installed-for-curl" --with-ca-bundle="/etc/ssl/certs/ca-certificates.crt" CFLAGS=-DTEST_OPENSSL_COEXIST