hostip: don't use the resolver for FQDN localhost #15676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Treat `[<any>.]localhost.` as fixed value 127.0.0.1 and ::1 instead of querying the resolver. Prior to this change, b5c0fe2 (precedes 7.85.0) did the same for non-FQDN `<any>.localhost`. Prior to this change, 1a0ebf6 (precedes 7.78.0) did the same for non-FQDN `localhost`. Ref: curl#15628 Closes #xxxxx
|
Analysis of PR #15676 at b52f8c31: Test 283 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1242 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
bagder
approved these changes
Dec 4, 2024
jay
added a commit
that referenced
this pull request
Dec 5, 2024
- Treat `[<any>.]localhost.` (ie localhost with FQDN period terminator) as fixed value 127.0.0.1 and ::1 instead of querying the resolver. Prior to this change, b5c0fe2 (precedes 7.85.0) did the same for non-FQDN `<any>.localhost`. Prior to this change, 1a0ebf6 (precedes 7.78.0) did the same for non-FQDN `localhost`. Ref: #15628 (comment) Closes #15676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[<any>.]localhost.as fixed value 127.0.0.1 and ::1 instead of querying the resolver.Prior to this change, b5c0fe2 (precedes 7.85.0) did the same for non-FQDN
<any>.localhost.Prior to this change, 1a0ebf6 (precedes 7.78.0) did the same for non-FQDN
localhost.Ref: #15628
Closes #xxxxx