cookie: parse only the exact expire date #15709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The date parser function is very forgiving and skips most "irrelevant" characters in its hunt for a date to figure out. Therefore it is important to make sure the date string is properly null terminated so that it does not accidentally parse a piece of whatever text follows after the date.
|
Analysis of PR #15709 at c26648a5: Test 575 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
danielgustafsson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date parser function is very forgiving and skips most "irrelevant" characters in its hunt for a date to figure out. Therefore it is important to make sure the date string is properly null terminated so that it does not accidentally parse a piece of whatever text follows after the date.