Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: remove 'detach/attach' functions from TLS handler struct #15776

Closed
wants to merge 5 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Dec 18, 2024

Unused since 7c8bae0

@bagder bagder added the TLS label Dec 18, 2024
@icing
Copy link
Contributor

icing commented Dec 18, 2024

So far, connection filters never had a NULL implementation of a function. Because almost all call "down". cntrl does not do that, so NULL will work (with the added check), but I am not sure if this is a good idea.

@bagder
Copy link
Member Author

bagder commented Dec 18, 2024

I was not really sure it was a good idea or not. I'll make it a dummy function instead to stick to the pattern.

@icing
Copy link
Contributor

icing commented Dec 18, 2024

I was not really sure it was a good idea or not. I'll make it a dummy function instead to stick to the pattern.

Life Curl_cf_def_cntrl? 😌

@testclutch
Copy link

Analysis of PR #15776 at 68e0cfb3:

Test http/test_14_auth.py::TestAuth::test_14_03_digest_put_auth[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 302bd6b Dec 18, 2024
@bagder bagder deleted the bagder/rm-tls-attach branch December 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants