-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: move pkg-config
names to Find modules
#15800
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
December 22, 2024 11:03
da2032c
to
9983784
Compare
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
December 24, 2024 11:00
6ba7f12
to
6eb6e71
Compare
Analysis of PR #15800 at 6eb6e718: Test 1198 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
December 26, 2024 11:59
6eb6e71
to
0519952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Find modules set and return their respective
pkg-config
module name(s) to the CMake build process, which then adds those
to the
Requires:
list.Before this patch,
pkg-config
module names were maintainted in twoseparate places. After this patch, they are maintained in the Find
modules for dependencies that have one (most do).
Re-align existing modules with this change: msh3, mbedtls, rustls.
These modules return their
pkg-config
module name only whendetected via
pkg-config
.Follow-up to d511ec8 #15573
pkg-config
module #15828