cmake: move pkg-config names to Find modules
#15800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
da2032c to
9983784
Compare
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
6ba7f12 to
6eb6e71
Compare
|
Analysis of PR #15800 at 6eb6e718: Test 1198 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
force-pushed
the
cm-pc-names-to-modules
branch
from
6eb6e71 to
0519952
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Make the Find modules set and return their respective `pkg-config` module name(s) to the CMake build process, which then adds those to the `Requires:` list. Before this patch, `pkg-config` module names were maintainted in two separate places. After this patch, they are maintained in the Find modules for dependencies that have one (most do). Re-align existing modules with this change: msh3, mbedtls, rustls. These modules return their `pkg-config` module name only when detected via `pkg-config`. Follow-up to d511ec8 curl#15573 Closes curl#15800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Find modules set and return their respective
pkg-configmodule name(s) to the CMake build process, which then adds those
to the
Requires:list.Before this patch,
pkg-configmodule names were maintainted in twoseparate places. After this patch, they are maintained in the Find
modules for dependencies that have one (most do).
Re-align existing modules with this change: msh3, mbedtls, rustls.
These modules return their
pkg-configmodule name only whendetected via
pkg-config.Follow-up to d511ec8 #15573
pkg-configmodule #15828