Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: move pkg-config names to Find modules #15800

Closed
wants to merge 36 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Dec 22, 2024

Make the Find modules set and return their respective pkg-config
module name(s) to the CMake build process, which then adds those
to the Requires: list.

Before this patch, pkg-config module names were maintainted in two
separate places. After this patch, they are maintained in the Find
modules for dependencies that have one (most do).

Re-align existing modules with this change: msh3, mbedtls, rustls.
These modules return their pkg-config module name only when
detected via pkg-config.

Follow-up to d511ec8 #15573


@testclutch
Copy link

Analysis of PR #15800 at 6eb6e718:

Test 1198 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@vszakats vszakats force-pushed the cm-pc-names-to-modules branch from 6eb6e71 to 0519952 Compare December 26, 2024 11:59
@vszakats vszakats closed this in fb1883d Dec 26, 2024
@vszakats vszakats deleted the cm-pc-names-to-modules branch December 26, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants