build: fix the tidy targets for autotools #15813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vszakats as "mr CI", do you have any thoughts on how to best run clang-tidy in GHA? The setup runs the tool on an existing build, so it would make sense to run it in one or a few existing jobs that are fairly "complete" and use as many features as possible. |
This comment was marked as outdated.
This comment was marked as outdated.
To make them run clang-tidy correctly. clang-tidy occasionally finds mistakes none of the other static code analyzers we use finds. Also added the -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling flag, to make it not complain about memcpy() "make tidy" in the build root works fine now. The previous clang-tidy CI job was removed in e43c3b3. It is probably time to bring it back.
bagder
force-pushed
the
bagder/clang-tidy
branch
from
2dcafe0 to
e04c8d8
Compare
I'll look into this locally, also for CMake, and see what can be done to have it in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make them run clang-tidy correctly. clang-tidy occasionally finds mistakes none of the other static code analyzers we use finds.
Also added the
-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling flag, to make it not complain about memcpy()
"make tidy" in the build root works fine now. The previous clang-tidy CI job was removed in e43c3b3. It is probably time to bring it back.