build: fix -Winline error when building with DEBUG #15815
Conversation
When building debug image avoid: ./lib/easy_lock.h:72:20: error: inlining failed in call to 'curl_simple_lock_lock': function not considered for inlining [-Werror=inline] Co-authored-by: Rudi Heitbaum <rudi@heitbaum.com> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
| -Winline # clang 1.0 gcc 1.0 | ||
| ) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
@vszakats we have discussed this option before. It is not used when configure sets picky options. Its value and use is questionable. Should we just never use it?
There was a problem hiding this comment.
Building with curl debug functionality + memory tracing + picky warnings
and CURL_WERROR explicitly enabled looks like an atypical build case
to me. ENABLE_DEBUG is meant to debug curl itself and basically removes
security.
Was this intented? If not, this might be a legit (though somewhat accidental)
warning sign, and possible replace ENABLE_DEBUG=ON with
-DCMAKE_BUILD_TYPE=Debug, which creates a secure/production curl
with debug info enabled.
In case it was intented and we want to make it pass, it's better to delete
this flag completely, rather then adding more conditionals.
PR → #15819
|
Analysis of PR #15815 at 7ce821cb: Test 285 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2003 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1501 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1190 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
To avoid this in certain debug build cases: ``` ./lib/easy_lock.h:72:20: error: inlining failed in call to 'curl_simple_lock_lock': function not considered for inlining [-Werror=inline] ``` Ref: curl#13596 Reported-by: Rudi Heitbaum Closes curl#15815
When building debug image avoid:
./lib/easy_lock.h:72:20: error: inlining failed in call to 'curl_simple_lock_lock': function not considered for inlining [-Werror=inline]
issues when building against DEBUG glibc