cmake/FindLDAP: avoid empty 'Requires' item when omitting pkg-config module
#15828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` module `list(APPEND ...)` does this automatically, but we're _prepending_ LDAP (to follow historical code and also autotools). `list(PREPEND ...)` would likely do that the same, but it requires CMake 3.15 so we do this manually and the manual method needs to skip the empty value manually. Follow-up to 49f2a23 curl#15273
1 task
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…` module `list(APPEND ...)` does this automatically, but we're _prepending_ LDAP (to follow historical code and also autotools). `list(PREPEND ...)` would likely do that the same, but it requires CMake 3.15 so we do this manually and the manual method needs to skip the empty value manually. Follow-up to 49f2a23 curl#15273 Closes curl#15828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list(APPEND ...)does this automatically, but we're prepending LDAP(to follow historical code and also autotools).
list(PREPEND ...)would likely do that the same, but it'd require CMake 3.15 so we do this
manually and the manual method needs to skip the empty value manually.
Follow-up to 49f2a23 #15273