cmake: add librtmp Find module
#15832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vszakats
changed the title
librtmplibrtmp Find module
|
Analysis of PR #15832 at 0ac5475f: Test http/test_14_auth.py::TestAuth::test_14_03_digest_put_auth[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
No longer used after this patch. Also it's probably better to add these to `CMAKE_REQUIRES_LIBRARIES` from the caller directly within a push/pop state.
It's required when linking librtmp statically.
vszakats
force-pushed
the
cm-find-rtmp
branch
from
0ac5475 to
f0dba42
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The new detection method also allows to enable librtmp without using OpenSSL as a curl TLS backend at the same time. Also: - implement manual version detection for librtmp. Version info is in hex. With CMake 3.13 and newer, extract it as a hex number. With earlier CMake version, just strip the leading zeroes. Doing more here seems overkill because librtmp has been standing at 2.3/2.4 for a decade now. Bumping into hex digits seems unlikely before deprecating CMake 3.13 support. librtmp advertises v2.4 via its `pkg-config` module, and v2.3 via its public header. The latter shows up in `curl -V` and either can be shown at configure-time depending on detection method. This isn't a curl bug. - GHA/macos: enable rtmp in a job. - apply the "half-detection" fix to the Find module. `librtmp` is also affected (in CI too), because it depends on libssl and libcrypto. Closes curl#15832
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Follow-up to 421e592 curl#15832
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- add `iphlpapi` library for c-ares. Ref: curl/curl-for-win@082d98b - fix to not add system libs if the dependency was not found. librtmp, Rustls, wolfSSL Follow-up to 421e592 curl#15832 Follow-up to 7bab201 curl#15193 Closes curl#16089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new detection method also allows to enable librtmp without using
OpenSSL as a curl TLS backend at the same time.
Also:
Version info is in hex. With CMake 3.13 and newer, extract it as a hex
number. With earlier CMake version, just strip the leading zeroes.
Doing more here seems overkill because librtmp has been standing
at 2.3/2.4 for a decade now. Bumping into hex digits seems unlikely
before deprecating CMake 3.13 support.
librtmp advertises v2.4 via its
pkg-configmodule, and v2.3 viaits public header. The latter shows up in
curl -Vand either canbe shown at configure-time depending on detection method.
This isn't a curl bug.
librtmpis also affected (in CI too), because it depends on libssl andlibcrypto.