checksrc: introduce 'banfunc' to ban specific functions #15835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'banfunc' and 'allowfunc' in .checksrc to specify which functions to ban or allow to be used. This saves us from having to edit the script going forward when we want to ban or allow specific functions. This replaces a set of previous rules and all banned functions are now checked with the BANNEDFUNC rule. There is a set of default banned functions, shown by invoking ./checksrc. Also, -a and -b options are added to specify allowed or banned functions on the command line.
|
Analysis of PR #15835 at c9c83d2a: Test http/test_07_upload.py::TestUpload::test_07_12_upload_seq_large[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 3207 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
yedayak
added a commit
to yedayak/curl
that referenced
this pull request
Jan 5, 2025
This isn't needed anymore after curl#15835, since banned functions are just allowed in general in `docs/examples/.checksrc`, and emits a warning when running make checksrc: `invalid warning specified in .checksrc: "SNPRINTF"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'banfunc' and 'allowfunc' in .checksrc to specify which functions to ban or allow to be used. This saves us from having to edit the script going forward when we want to ban or allow specific functions.
This replaces a set of previous rules and all banned functions are now checked with the BANNEDFUNC rule.
There is a set of default banned functions, shown by invoking ./checksrc.
Also, -a and -b options are added to specify allowed or banned functions on the command line.