file: drop OPEN_NEEDS_ARG3 option
#15882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wolfssl-master builds fail. wolfssl bumped its soversion, and https://github.com/curl/curl/actions/runs/12566280972/job/35031554418?pr=15882#step:20:17 It's due to ngtcp2 which wasn't rebuilt and keeps linking to the old soversion: https://github.com/curl/curl/actions/runs/12566280972/job/35031554418?pr=15882#step:16:1941 Known good: https://github.com/curl/curl/actions/runs/12554935980/job/35004339929 |
|
Analysis of PR #15882 at 9e32f7ed: Test http/test_09_push.py::TestPush::test_09_02_h2_push[0] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
changed the title
OPEN_NEEDS_ARG3OPEN_NEEDS_ARG3 branch
vszakats
changed the title
OPEN_NEEDS_ARG3 branchOPEN_NEEDS_ARG3 option
bagder
approved these changes
Jan 1, 2025
vszakats
added a commit
that referenced
this pull request
Jan 2, 2025
ngtcp2 depends on crypto backends. nghttp2 depends on ngtcp2 and nghttp3 (for nghttpx server used in pytests). Before this patch, ngtcp2, nghttp2 weren't rebuilt when their dependencies changes. This worked fine until wolfSSL bumped its soversion and caused CI to fail because ngtcp2 was not rebuilt and was still referring to the old soname that was no longer offered by the wolfSSL package. Make sure to rebuild ngtcp2/nghttp2 when any of their dependencies bump. To avoid rebuilding everything on every wolfSSL commit, switch to use wolfSSL stable versions. Bug: #15882 (comment) Closes #15885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not set since 1bf3643 #8362 (2022)
Added in 0088382 (2009) for VxWorks.