-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typecheck-gcc: add support for CURLINFO_OFF_T #1592
Conversation
The problem is that the GCC-release combination of the travis build runs on OSX. The default GCC is 4.2.1 there, which is not supported by typecheck-gcc.h. Maybe it could be changed to use gcc-4.8 instead, or the Linux GCC build switched to release mode and the OSX GCC build to debug mode? |
I think it is possible. My googling found this example of someone doing it.
They could indeed, or we could also just add a build if we need to! It's just to make a PR with a .travis.yml update to try it out! |
Ah, so the changed .travis.yml is immediately used for the PR? That's nice! |
Coverage decreased (-0.008%) to 73.801% when pulling 1a0602b36f61a570094fa70b7b5d64a3b3f1c836 on MarcelRaad:typecheck_off_t_info into b778ae4 on curl:master. |
Yes, exactly! |
1a0602b
to
cab32a4
Compare
Coverage increased (+0.01%) to 73.793% when pulling cab32a4e5efde385ce0da32f8692162d426a10c5 on MarcelRaad:typecheck_off_t_info into 0feb762 on curl:master. |
typecheck-gcc expected curl_socket_t instead of curl_off_t arguments for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run locally. Closes curl#1592
cab32a4
to
01d9670
Compare
Thanks! |
typecheck-gcc expected curl_socket_t instead of curl_off_t arguments
for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run
locally.