New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheck-gcc: add support for CURLINFO_OFF_T #1592

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MarcelRaad
Member

MarcelRaad commented Jun 19, 2017

typecheck-gcc expected curl_socket_t instead of curl_off_t arguments
for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run
locally.

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Jun 19, 2017

The problem is that the GCC-release combination of the travis build runs on OSX. The default GCC is 4.2.1 there, which is not supported by typecheck-gcc.h. Maybe it could be changed to use gcc-4.8 instead, or the Linux GCC build switched to release mode and the OSX GCC build to debug mode?

@bagder

This comment has been minimized.

Member

bagder commented Jun 19, 2017

Maybe it could be changed to use gcc-4.8 instead

I think it is possible. My googling found this example of someone doing it.

or the Linux GCC build switched to release mode and the OSX GCC build to debug mode?

They could indeed, or we could also just add a build if we need to! It's just to make a PR with a .travis.yml update to try it out!

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Jun 19, 2017

It's just to make a PR with a .travis.yml update to try it out!

Ah, so the changed .travis.yml is immediately used for the PR? That's nice!

@coveralls

This comment has been minimized.

coveralls commented Jun 19, 2017

Coverage Status

Coverage decreased (-0.008%) to 73.801% when pulling 1a0602b on MarcelRaad:typecheck_off_t_info into b778ae4 on curl:master.

@bagder

This comment has been minimized.

Member

bagder commented Jun 19, 2017

Yes, exactly!

@bagder

bagder approved these changes Jun 20, 2017

@MarcelRaad MarcelRaad force-pushed the MarcelRaad:typecheck_off_t_info branch from 1a0602b to cab32a4 Jun 20, 2017

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Jun 20, 2017

typecheck-gcc: add support for CURLINFO_OFF_T
typecheck-gcc expected curl_socket_t instead of curl_off_t arguments
for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run
locally.

Closes curl#1592
@coveralls

This comment has been minimized.

coveralls commented Jun 20, 2017

Coverage Status

Coverage increased (+0.01%) to 73.793% when pulling cab32a4 on MarcelRaad:typecheck_off_t_info into 0feb762 on curl:master.

typecheck-gcc: add support for CURLINFO_OFF_T
typecheck-gcc expected curl_socket_t instead of curl_off_t arguments
for CURLINFO_OFF_T. Detected by test1521, unfortunately only when run
locally.

Closes #1592

@MarcelRaad MarcelRaad force-pushed the MarcelRaad:typecheck_off_t_info branch from cab32a4 to 01d9670 Jun 20, 2017

@coveralls

This comment has been minimized.

coveralls commented Jun 20, 2017

Coverage Status

Coverage increased (+0.01%) to 73.801% when pulling 01d9670 on MarcelRaad:typecheck_off_t_info into 651e04c on curl:master.

@MarcelRaad MarcelRaad deleted the MarcelRaad:typecheck_off_t_info branch Jun 21, 2017

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Jun 21, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment