msvc: fix building with HAVE_INET_NTOP and MSVC <=1900
#15923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` lib/hostip.c(144): error C2220: warning treated as error - no 'object' file generated lib/hostip.c(144): warning C4090: 'function': different 'const' qualifiers lib/hostip.c(151): warning C4090: 'function': different 'const' qualifiers ``` https://ci.appveyor.com/project/curlorg/curl/builds/51277632/job/r41upsidsavaxvl2#L179
vszakats
changed the title
HAVE_INET_NTOP and MSVC <=1900
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 7, 2025
Follow-up to 08ff33e curl#15923 Follow-up to 50f6a6b curl#15926
vszakats
added a commit
that referenced
this pull request
Jan 7, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
MSVC 1900 and older is missing a `const` specifier in the `inet_ntop()` declaration for the second argument. A workaround was in place for it in cmake, but it didn't cover all necessary versions. Replace the workaround with a different one, move it to `lib/inet_ntop.c` and extend to all necessary MSVC versions. Also add CI jobs for the older MSVC versions: 2013, 2015, 2017. Closes curl#15923
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Also to align with existing VS2010. Keeping the VS2008 job first to give a quick sniff test for MSVC builds. Follow-up to 08ff33e curl#15923 Follow-up to 50f6a6b curl#15926 Closes curl#15932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC 1900 and older is missing a
constspecifier in theinet_ntop()declaration for the second argument. A workaround was in place for it
in cmake, but it didn't cover all necessary versions.
Replace the workaround with a different one, move it to
lib/inet_ntop.cand extend to all necessary MSVC versions.
Also add CI jobs for the older MSVC versions: 2013, 2015, 2017.