Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content_encoding: namespace GZIP flag constants #15929

Closed
wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 7, 2025

To avoid collision with a 3rd-party RESERVED symbols.

This symbol is used in the public header of MSH3 0.7.0.

To avoid collision with a 3rd-party `RESERVED` (e.g. on Windows).
@vszakats vszakats added Windows Windows-specific HTTP/3 h3 or quic related labels Jan 7, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Jan 7, 2025
To avoid collision with a 3rd-party `RESERVED` symbols.

This symbol is used in the public header of MSH3 0.7.0.

Closes curl#15929
@vszakats
Copy link
Member Author

vszakats commented Jan 7, 2025

This makes the MSH3 CMake build go a little further, but then fails with a bunch of other issues, first this (autotools does build, but fails 20+ tests):

/home/runner/msh3/include/msh3.h:377:18: error: width of ‘RESERVED’ exceeds its type
  377 |             bool RESERVED                 : 5;
      |                  ^~~~~~~~
/home/runner/msh3/include/msh3.h:490:18: error: width of ‘RESERVED’ exceeds its type
  490 |             bool RESERVED            : 7;
      |                  ^~~~~~~~

Ref: https://github.com/curl/curl/actions/runs/12655411540/job/35265668864#step:35:42

Before: https://github.com/curl/curl/actions/runs/12655297071/job/35265287150
After: https://github.com/curl/curl/actions/runs/12655411540/job/35265668864

@vszakats vszakats closed this in 24ef9de Jan 7, 2025
@vszakats vszakats deleted the lib-RESERVED branch January 7, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build HTTP/3 h3 or quic related tidy-up Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants