msvc: drop checks for ancient versions #15946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop version guard for
__inline.Supported since
_MSC_VER1000.Visual C++, 32-bit, version 4.0 (1996)
drop version guard for
__declspec(noreturn)and__forceinline.Supported since
_MSC_VER1200.Visual C++, 32-bit, version 6.0 (1998)
For ancient versions, it's possible to override the default behaviour
by setting these macros via
CPPFLAGS:CURL_NORETURN,CURL_INLINE,CURL_FORCEINLINEPotential candidate:
_INTEGRAL_MAX_BITS: It's always 64 since_MSC_VER1400,(year 2005) possibly earlier, since 1300 (year 2002).
Though the oldest MSVC supported by curl build tools is 1200.
Also checks for version 900. Tackle this in another PR.