Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: enable typecheck-gcc warnings #1595

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Jun 20, 2017

  • switch debug and release configurations so that we get an optimized
    build with GCC 4.3+ as required by typecheck-gcc
  • enable compiler warnings also for release builds

Testing if this works before merging #1592.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jun 20, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @sieben and @jactry to be potential reviewers.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage increased (+0.01%) to 73.801% when pulling 64083bc on MarcelRaad:travis_typecheck into 651e04c on curl:master.

- switch debug and release configurations so that we get an optimized
  build with GCC 4.3+ as required by typecheck-gcc
- enable warnings-as-errors for release builds
  (which have warnings disabled)
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:travis_typecheck branch from 64083bc to 423d0e4 Jun 20, 2017
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Jun 20, 2017

When switching debug and release and enabling warnings for release, the warnings showed up in the build log, but the build was green anyway. Testing --enable-werror for release now (without --enable-warnings).

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Jun 20, 2017

Ah, as the warnings happen to be in a test, for which --enable-werror has no effect, the build still succeeds.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.01%) to 73.777% when pulling 423d0e4 on MarcelRaad:travis_typecheck into 651e04c on curl:master.

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Jun 21, 2017

So this is the version I'd like to merge. It would at least error out on typecheck-gcc warnings (and other warnings enabled by default) in libcurl and the curl tool.

@bagder
bagder approved these changes Jun 21, 2017
@MarcelRaad MarcelRaad deleted the MarcelRaad:travis_typecheck branch Jun 21, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.