Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write-out variable 'tls_earlydata' #15956

Closed
wants to merge 4 commits into from
Closed

Conversation

icing
Copy link
Contributor

@icing icing commented Jan 9, 2025

Add the write-out variable 'tls_earlydata' to inspect the amount of TLSv1.3 early data that had been sent.

@testclutch
Copy link

Analysis of PR #15956 at 585f2996:

Test http/test_14_auth.py::TestAuth::test_14_03_digest_put_auth[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1631 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1632 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 445 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@icing icing force-pushed the var-tls_earlydata branch from 585f299 to e50e9d4 Compare January 10, 2025 07:40
@icing
Copy link
Contributor Author

icing commented Jan 10, 2025

The msvc jobs seem troubled, but should not be related to this PR, I think.

@jay
Copy link
Member

jay commented Jan 11, 2025

The errors are in the windows cmake jobs but I don't see how this could be related. However the ancestor commit that you branched from does not have the same failures 386f570. I think it is unusual that they all failed. I set the jobs to run again

@vszakats
Copy link
Member

The errors are in the windows cmake jobs but I don't see how this could be related. However the ancestor commit that you branched from does not have the same failures 386f570. I think it is unusual that they all failed. I set the jobs to run again

I did re-run them also. MSVC tests fail consistenly in all jobs where run. Maybe worth rebasing on master to rule a bad base out.

@icing icing force-pushed the var-tls_earlydata branch from 7119ef6 to 63853e9 Compare January 13, 2025 09:32
@icing
Copy link
Contributor Author

icing commented Jan 13, 2025

The errors are in the windows cmake jobs but I don't see how this could be related. However the ancestor commit that you branched from does not have the same failures 386f570. I think it is unusual that they all failed. I set the jobs to run again

I did re-run them also. MSVC tests fail consistenly in all jobs where run. Maybe worth rebasing on master to rule a bad base out.

Just rebased this. Thanks.

@bagder bagder added the feature-window A merge of this requires an open feature window label Jan 13, 2025
@icing icing requested a review from bagder February 20, 2025 14:43
@bagder bagder closed this in 54c07fd Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmdline tool feature-window A merge of this requires an open feature window tests
Development

Successfully merging this pull request may close these issues.

5 participants