-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system.h: drop compilers lacking 64-bit integer type (Windows/MS-DOS) #15957
Conversation
32-bit compilers are supposed to still be supported as long as they supply a
64-bit integer type. Do none of these do that? If so, the description could be
clarified.
|
Indeed, fixed it after realizing it! I have no way to actually test these platforms, but it's more than unlikely |
At least one DOS compiler I'm aware of (Watcom C) supports a 64-bit type and it
wouldn't surprise me if others did, too. AIUI it doesn't have to be long, just
some 64-bit type that curl can use. At least one person is still producing
recent curl builds under DOS, so I wouldn't be too hasty to remove that
support.
|
This doesn't remove MS-DOS support. DJGPP still builds in CI. It drops support for DJGPP v1, using
As for Watcom, there was no mention of What's deleted here is ancient or defunct compilers and versions. |
As for Borland C++, 5.5 was the first free version capable of |
I am a little confused about this issue. Does this mean that support for |
I should clarify that I have two curl builds, 32-bit and 64-bit. Both are required. |
I am a little confused about this issue. Does this mean that support for long
long is fine or does it mean that int or long must be 64-bit.
64-bit long long is fine. long is usually 32-bits on 32-bit compilers and curl
still supports those. This discussion should be discriminating between them.
|
long is also 32 bit on 64 bit Windows and possibly some other odd platforms. As long (pun not intended) as there is a 64 bit type available, we should be good. |
For targets deleted in this PR, this mapping looked like: #define CURL_TYPEOF_CURL_OFF_T long As opposed to targets with 64-bit type support, where it's one of these: #define CURL_TYPEOF_CURL_OFF_T long long
#define CURL_TYPEOF_CURL_OFF_T __int64 I understand these platform may theoretically provide 64-bit I don't think these ancient compilers provided 64-bit types, All deleted targets are exclusively Windows and MS-DOS What am I missing? |
This reverts commit cf7f751.
989be21
to
5609360
Compare
I am not sure but I think |
Moved that update to #15966 and did the same for |
__GO32__
) (MS-DOS)DJGPP 2.x support remains unchanged.
These targets mapped
curl_off_t
tolong
. On Windows and MS-DOSlong
is always 32-bit.curl requires C compilers supporting 64-bit
curl_off_t
type since8356826 #10597 (v8.0.0).
Also: drop remaining
__GO32__
and Salford C guards.w/o whitespace: https://github.com/curl/curl/pull/15957/files?w=1