-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msvc: tidy up _CRT_*_NO_DEPRECATE
definitions
#15960
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_CRT_*
definitions_CRT_*
definitions
- drop version guard (on ancient MSVC version these macro are a no-op). - update comment. - sync values with CMake.
11e6cf6
to
ef3ccb8
Compare
This reverts commit 86d9d37.
_CRT_*
definitions_CRT_*_NO_DEPRECATE
definitions
MarcelRaad
approved these changes
Jan 11, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 8, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 8, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 8, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 9, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 9, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedupe and migrate MSVC-specific warning suppressions to
curl_setup.h
.Make cmake set
_CRT_SECURE_NO_DEPRECATE
for examples and standalonetests, and stop setting
_CRT_NONSTDC_NO_DEPRECATE
for them.Details:
curl_setup.h
fromconfig-win32*.h
.curl_setup.h
.docs/examples
andtests/http/clients
,which do not use
curl_setup.h
._CRT_NONSTDC_NO_DEPRECATE
for examples and tests.They build fine without.
w/o whitespace: https://github.com/curl/curl/pull/15960/files?w=1