tidy-up: curl_setup.h, curl_setup_once.h, config-win32ce.h
#15967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
curl_setup.h, curl_setup_once.hcurl_setup.h, curl_setup_once.h, config-win32ce.h
|
Analysis of PR #15967 at 00453b9c: Test http/test_14_auth.py::TestAuth::test_14_03_digest_put_auth[0-h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1191 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1194 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2201 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 498 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
jay
reviewed
Jan 11, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- drop unused `LIBIDN_REQUIRED_VERSION` macro. Unused since 9c91ec7 - drop compatibility error for `CURL_WANTS_CA_BUNDLE_ENV`. This macro was once set by `Makefile.mk` and Watcom makefiles. They are no longer supported, making the compatibility message moot. Follow-up to 7d73465 curl#1542 (2017) Follow-up to c2aeb1b curl#1538 (2017) - document last MSVC supporting the `!_MT` condition Ref: https://stackoverflow.com/questions/2278919/are-the-time-functions-of-msvc-thread-safe - flatten an `#if` tree, prefer `#ifdef`. - fix/adjust indentation, whitespace. Closes curl#15967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop unused
LIBIDN_REQUIRED_VERSIONmacro.Unused since 9c91ec7
drop compatibility error for
CURL_WANTS_CA_BUNDLE_ENV.This macro was once set by
Makefile.mkand Watcom makefiles.They are no longer supported, making the compatibility message moot.
Follow-up to 7d73465 lib/curl_setup.h: remove CURL_WANTS_CA_BUNDLE_ENV #1542 (2017)
Follow-up to c2aeb1b The curl-ca-bundle.crt file is ignored on Windows, except if CURL_CA_BUNDLE is set #1538 (2017)
document last MSVC supporting the
!_MTconditionRef: https://stackoverflow.com/questions/2278919/are-the-time-functions-of-msvc-thread-safe
flatten an
#iftree, prefer#ifdef.fix/adjust indentation, whitespace.
w/o whitespace: https://github.com/curl/curl/pull/15967/files?w=1