configure: streamline Windows large file feature check #15971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch the feature check was running an `AC_COMPILE` check that always succeeded. The only Windows toolchain autotools supports is mingw. Of these, curl only supports mingw-w64. All mingw-w64 versions support large files. This allows to drop the check and assume it supported. Drop the feature check altogether for non-native Windows targets. Ref: curl#15968 (comment)
jay
reviewed
Jan 12, 2025
| esac | ||
| case "$curl_win32_has_largefile" in | ||
| yes) | ||
| if test x"$enable_largefile" = 'xno'; then |
Member
There was a problem hiding this comment.
is this check necessary, like what would possibly set enable_largefile false at this point and should we allow it for windows? i don't see where it's defined but does it have something to do with --disable-largefile?
Member
Author
There was a problem hiding this comment.
Yes, it's a ./configure option:
--disable-largefile omit support for large files
I think it's built-in, and also applies to other platforms, but I didn't dig into it beyond a Windows test build.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 12, 2025
Before this patch the `CURL_CHECK_WIN32_LARGEFILE` feature check was running an `AC_COMPILE` snippet that always succeeded. (except for Windows CE, which isn't supported in other parts of `./configure` yet.) The only Windows toolchain autotools supports is mingw. Of them, curl only supports mingw-w64. All mingw-w64 versions support large files. This allows to drop the check and assume it supported on Windows. To not lose Windows CE support, rework that too, without using `AC_COMPILE`. Drop the feature check altogether for non-Windows targets. Ref: curl#15968 (comment) Follow-up to 7eb4ddb curl#15968 Closes curl#15971
Member
Author
|
After recent few tidy ups, there may be a chance to merge |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Before this patch the `CURL_CHECK_WIN32_LARGEFILE` feature check was running an `AC_COMPILE` snippet that always succeeded. (except for Windows CE, which isn't supported in other parts of `./configure` yet.) The only Windows toolchain autotools supports is mingw. Of them, curl only supports mingw-w64. All mingw-w64 versions support large files. This allows to drop the check and assume it supported on Windows. To not lose Windows CE support, rework that too, without using `AC_COMPILE`. Drop the feature check altogether for non-Windows targets. Ref: curl#15968 (comment) Follow-up to 7eb4ddb curl#15968 Closes curl#15971
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
(Did not cause issues in this particular case.) Follow-up to a118452 curl#15971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch the
CURL_CHECK_WIN32_LARGEFILEfeature check wasrunning an
AC_COMPILEsnippet that always succeeded. (except forWindows CE, which isn't supported in other parts of
./configureyet.)The only Windows toolchain autotools supports is mingw. Of them, curl
only supports mingw-w64. All mingw-w64 versions support large files.
This allows to drop the check and assume it supported on Windows. To not
lose Windows CE support, rework that too, without using
AC_COMPILE.Drop the feature check altogether for non-Windows targets.
Ref: #15968 (comment)
Follow-up to 7eb4ddb #15968
w/o whitespace: https://github.com/curl/curl/pull/15971/files?w=1