-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: streamline Windows large file feature check #15971
Conversation
Before this patch the feature check was running an `AC_COMPILE` check that always succeeded. The only Windows toolchain autotools supports is mingw. Of these, curl only supports mingw-w64. All mingw-w64 versions support large files. This allows to drop the check and assume it supported. Drop the feature check altogether for non-native Windows targets. Ref: curl#15968 (comment)
esac | ||
case "$curl_win32_has_largefile" in | ||
yes) | ||
if test x"$enable_largefile" = 'xno'; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this check necessary, like what would possibly set enable_largefile
false at this point and should we allow it for windows? i don't see where it's defined but does it have something to do with --disable-largefile
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a ./configure
option:
--disable-largefile omit support for large files
I think it's built-in, and also applies to other platforms, but I didn't dig into it beyond a Windows test build.
Before this patch the `CURL_CHECK_WIN32_LARGEFILE` feature check was running an `AC_COMPILE` snippet that always succeeded. (except for Windows CE, which isn't supported in other parts of `./configure` yet.) The only Windows toolchain autotools supports is mingw. Of them, curl only supports mingw-w64. All mingw-w64 versions support large files. This allows to drop the check and assume it supported on Windows. To not lose Windows CE support, rework that too, without using `AC_COMPILE`. Drop the feature check altogether for non-Windows targets. Ref: curl#15968 (comment) Follow-up to 7eb4ddb curl#15968 Closes curl#15971
After recent few tidy ups, there may be a chance to merge |
Before this patch the
CURL_CHECK_WIN32_LARGEFILE
feature check wasrunning an
AC_COMPILE
snippet that always succeeded. (except forWindows CE, which isn't supported in other parts of
./configure
yet.)The only Windows toolchain autotools supports is mingw. Of them, curl
only supports mingw-w64. All mingw-w64 versions support large files.
This allows to drop the check and assume it supported on Windows. To not
lose Windows CE support, rework that too, without using
AC_COMPILE
.Drop the feature check altogether for non-Windows targets.
Ref: #15968 (comment)
Follow-up to 7eb4ddb #15968
w/o whitespace: https://github.com/curl/curl/pull/15971/files?w=1