cmake: drop VS2010 "Dialog Hell" workaround added in 2013 #15973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version at the time this workaround was added via a94a68a (2013-02-04) https://github.com/Kitware/CMake/releases/tag/v2.8.10 (2012-10-31) https://github.com/Kitware/CMake/releases/tag/v2.8.11 (2013-05-15)
Added in a94a68a, without details, referring to a CMake bug, but without a version number. The latst version was 2.8.10 at the time. This is no longer supported with curl. It seems safe to assume this has been fixed in the oldest CMake version supported by curl (3.7) or in a newer version up to v3.24 which was the last CMake supporting VS2010 natively.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Delete the workaround added via a94a68a (2013-02-04). The commit message has no details. The comment mentions "Dialog Hell", and seems to fix CMake missing to regenerate `CURL.sln` with VS2010. It also added a FIXME saying the workaround can be deleted with future versions of CMake. At the time CMake's latest version was v2.8.10. curl now requires v3.7 (2018) minimum, and v3.24 (2022) was the latest CMake natively supporting VS2010. Assume this has since been fixed. Also: format an MSVC version reference in comment. Closes curl#15973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the workaround added via a94a68a
(2013-02-04). The commit message has no details. The comment mentions
"Dialog Hell", and seems to fix CMake missing to regenerate
CURL.slnwith VS2010. It also added a FIXME saying the workaround can be deleted
with future versions of CMake.
At the time CMake's latest version was v2.8.10.
curl now requires v3.7 (2018) minimum, and v3.24 (2022) was the
latest CMake natively supporting VS2010. Assume this has since been
fixed.
Also: format an MSVC version reference in comment.