Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: drop VS2010 "Dialog Hell" workaround added in 2013 #15973

Closed
wants to merge 4 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 12, 2025

Delete the workaround added via a94a68a
(2013-02-04). The commit message has no details. The comment mentions
"Dialog Hell", and seems to fix CMake missing to regenerate CURL.sln
with VS2010. It also added a FIXME saying the workaround can be deleted
with future versions of CMake.

At the time CMake's latest version was v2.8.10.

curl now requires v3.7 (2018) minimum, and v3.24 (2022) was the
latest CMake natively supporting VS2010. Assume this has since been
fixed.

Also: format an MSVC version reference in comment.

Added in a94a68a, without details,
referring to a CMake bug, but without a version number. The latst
version was 2.8.10 at the time. This is no longer supported with
curl. It seems safe to assume this has been fixed in the oldest
CMake version supported by curl (3.7) or in a newer version up to
v3.24 which was the last CMake supporting VS2010 natively.
@vszakats vszakats added cmake Windows Windows-specific tidy-up labels Jan 12, 2025
@vszakats vszakats closed this in 14e2794 Jan 13, 2025
@vszakats vszakats deleted the cm-drop-workaround branch January 13, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant