msvc: drop support for VS2005 and older #16004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
c9f23eb to
f9bf354
Compare
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
76d4fde to
ea02cef
Compare
MarcelRaad
approved these changes
Jan 15, 2025
|
I suggest hard fail so the user knows what's up, for example in curl_setup: /* Visual Studio 2008 is the minimum Visual Studio version we support.
Workarounds for older versions of Visual Studio have been removed. */
#if defined(_MSC_VER) && (_MSC_VER < 1500)
#error "Ancient versions of Visual Studio are no longer supported due to bugs."
#endifAlso the commit message should have a reference to our discussion in #15972 |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 15, 2025
vszakats
added
the
feature-window
|
Pushing this to the next feature window. This allows to have the current |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 16, 2025
vszakats
force-pushed
the
w-msvc-drop-old
branch
2 times, most recently
from
924f58b to
43dee1e
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 20, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 22, 2025
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
43dee1e to
ca689ca
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 22, 2025
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
ca689ca to
32cea84
Compare
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
32cea84 to
0672840
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 16, 2025
vszakats
force-pushed
the
w-msvc-drop-old
branch
from
0672840 to
fc7af28
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 3, 2025
Regression from e0fd579 curl#16004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_fseeki64())_fseeki64())HAVE_LONGLONG(VS2003+)time_t(VS2005+)Authored-by: Jay Satiro
Follow-up to 308437a #15992
Ref: #15972
w/o whitespace: https://github.com/curl/curl/pull/16004/files?w=1