Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doh: cleanups and extended HTTPS RR code #16007

Closed
wants to merge 4 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 15, 2025

In preparation for using HTTPS outside of ECH, the parser now also extracts the port number.

Plus some other minor cleanups.

@bagder bagder added the name lookup DNS and related tech label Jan 15, 2025
In preparation for using HTTPS outside of ECH, the parser now also
extracts the port number.

Plus other minor cleanups.
@bagder bagder force-pushed the bagder/https-rr-fixups branch from eace8b1 to 1d141c5 Compare January 15, 2025 09:32
This of course makes it trickier to test, as this adds a third DoH
request
Adjusted runtests and server/disabled.c to include "HTTPSRR" as a feature in
the test suite.
@github-actions github-actions bot added the tests label Jan 15, 2025
There's no point in storing everything in string format.
Skip ALPNs we do not support.

enter the commit message for your changes. Lines starting
@bagder bagder closed this in 5d70a5c Jan 15, 2025
bagder added a commit that referenced this pull request Jan 15, 2025
When enabled in the build.

Update test2100: verify with HTTPS RR included

Adjust runtests and server/disabled.c to include "HTTPSRR" as a feature
in the test suite.

Also, decode the ALPN list in HTTPS records straight into IDs. There's
no point in storing everything in string format. Skip ALPNs we do not
support.

Closes #16007
@bagder bagder deleted the bagder/https-rr-fixups branch January 15, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name lookup DNS and related tech tests
Development

Successfully merging this pull request may close these issues.

1 participant