Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools: add support for mingw UWP builds #16020

Closed
wants to merge 16 commits into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 16, 2025

To match cmake builds.

  • GHA/windows: allow autotools UWP builds.
  • detect UWP and add to buildinfo.txt.
    Consider it enabled if CPPFLAGS contains -DWINSTORECOMPAT.
  • disable telnet with UWP.
  • enable Unicode with UWP.
  • do not use wldap32 with UWP.
  • do not enable USE_WIN32_CRYPTO with UWP.
  • make sure to link to ws2_32 in UWP builds.
    To fix undefined reference to in6addr_any'when linkingtests/server` programs. More in the comment.

w/o whitespace: https://github.com/curl/curl/pull/16020/files?w=1

```
gcc.exe: fatal error: cannot read spec file 'D:acurlcurlgcc-specs-uwp': No such file or directory
compilation terminated.
make[1]: *** [Makefile:3154: libcurl_la-timediff.lo] Error 1
libtool: compile:  windres -I../../include -i ../../lib/libcurl.rc -o libcurl.o >/dev/null 2>&1
libtool: compile:  gcc -DHAVE_CONFIG_H -I../../include -I../lib -I../../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -DWINSTORECOMPAT -DWINAPI_FAMILY=WINAPI_FAMILY_APP -fvisibility=hidden -specs=D:acurlcurlgcc-specs-uwp -Werror-implicit-function-declaration -O2 -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wbad-function-cast -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wstrict-aliasing=3 -Wattributes -Wdiv-by-zero -Wformat-security -Wmissing-field-initializers -Wmissing-noreturn -Wunreachable-code -Wunused-parameter -Wpragmas -Wredundant-decls -Wcast-align -Waddress -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wsign-conversion -Wno-error=sign-conversion -Wvla -ftree-vrp -Wno-pedantic-ms-format -Wdouble-promotion -Wtrampolines -Wformat=2 -Warray-bounds=2 -Wshift-negative-value -Wshift-overflow=2 -Wnull-dereference -fdelete-null-pointer-checks -Wduplicated-cond -Wunused-const-variable -Wduplicated-branches -Wrestrict -Walloc-zero -Wformat-truncation=2 -Wimplicit-fallthrough -Warith-conversion -Wenum-conversion -Wno-system-headers -Werror -pedantic-errors -c libcurl_unity.c  -DDLL_EXPORT -DPIC -o .libs/libcurl_la-libcurl_unity.o
gcc.exe: fatal error: cannot read spec file 'D:acurlcurlgcc-specs-uwp': No such file or directory
compilation terminated.
```
https://github.com/curl/curl/actions/runs/12809659016/job/35714988411#step:10:31
@vszakats vszakats added build Windows Windows-specific labels Jan 16, 2025
@github-actions github-actions bot added the CI Continuous Integration label Jan 16, 2025
@vszakats vszakats closed this in f7bb6c1 Jan 16, 2025
@vszakats vszakats deleted the am-uwp branch January 16, 2025 18:43
vszakats added a commit that referenced this pull request Jan 17, 2025
- limit UWP detection to native Windows.
- add missing double-quotes to variable.
- drop interlock and sync order in buildinfo flags.

Follow-up to 56a74fa #16014
Follow-up to f7bb6c1 #16020

Closes #16027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Continuous Integration Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

1 participant