libzstd: use custom memory functions #16028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using automatic zstd decoding from libcurl, libcurl's custom allocators are not passed through to libzstd.
Solution
To configure libzstd's custom allocators, we must pass them through "advanced" APIs:
These APIs don't are not usable without static linking (as they're considered experimental and unstable, avoiding dynamic linking against a breaking change):
So for curl users who are using zstd, if they want to set custom allocators they should pass in a compiler flag
ZSTD_STATIC_LINKING_ONLY
, example:This function was introduced in v0.8.1 in 2016 here: facebook/zstd@be6180c (signature hasn't changed since then afaict).