windows: merge config-win32ce.h into config-win32.h
#16038
Conversation
| #undef USE_WIN32_LDAP | ||
| #define HAVE_LDAP_URL_PARSE 1 | ||
| #else | ||
| #elif !defined(CURL_WINDOWS_UWP) && !defined(UNDER_CE) |
There was a problem hiding this comment.
lib/config-win32.h had USE_WIN32_LDAP enabled, just without the HAVE_LDAP_SSL. Is the behavior change on purpose?
There was a problem hiding this comment.
Well spotted! It did indeed, but it also had #define CURL_DISABLE_LDAP 1 later in the file, so LDAP was left unused by config-win32ce.h.
LDAP is also broken/missing with CeGCC. As for MSVC, my botched (non-standard) MSVC 2008 toolchain for WinCE has both wldap32 implib and winldap.h header, but no subauth.h, required by lib/ldap.c. This may not be a 100% indicator.
Internet search gives mixed signals. It may have depended on WinCE version or other factors. (or support may be partial, and/or needing WinCE specific tweaks.)
I went back and forth with its status for non-CeCC in this PR, so definitive info would be nice.
They were more or less the same, but each missed some things the other had. Windows CE is a subset of Win32, make the headers reflect that and avoid duplications. Ref: curl#15975 Closes curl#16038
2 participants
They were more or less the same, but each missed some things the other
had. Windows CE is a subset of Win32, make the headers reflect that and
avoid duplications.
Ref: #15975