Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: merge config-win32ce.h into config-win32.h #16038

Closed
wants to merge 4 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 17, 2025

They were more or less the same, but each missed some things the other
had. Windows CE is a subset of Win32, make the headers reflect that and
avoid duplications.

Ref: #15975

@vszakats vszakats added build Windows Windows-specific labels Jan 17, 2025
#undef USE_WIN32_LDAP
#define HAVE_LDAP_SSL_H 1
#define HAVE_LDAP_URL_PARSE 1
#elif defined(CURL_HAS_OPENLDAP_LDAPSDK)
#undef USE_WIN32_LDAP
#define HAVE_LDAP_URL_PARSE 1
#else
#elif !defined(CURL_WINDOWS_UWP) && !defined(UNDER_CE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/config-win32.h had USE_WIN32_LDAP enabled, just without the HAVE_LDAP_SSL. Is the behavior change on purpose?

Copy link
Member Author

@vszakats vszakats Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! It did indeed, but it also had #define CURL_DISABLE_LDAP 1 later in the file, so LDAP was left unused by config-win32ce.h.

LDAP is also broken/missing with CeGCC. As for MSVC, my botched (non-standard) MSVC 2008 toolchain for WinCE has both wldap32 implib and winldap.h header, but no subauth.h, required by lib/ldap.c. This may not be a 100% indicator.

Internet search gives mixed signals. It may have depended on WinCE version or other factors. (or support may be partial, and/or needing WinCE specific tweaks.)

I went back and forth with its status for non-CeCC in this PR, so definitive info would be nice.

@vszakats vszakats closed this in 292d81c Jan 20, 2025
@vszakats vszakats deleted the merge-config-win32-win32ce branch January 20, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants