Fix build with mbedtls v3.6 PSA but without TLS 1.3 or session tickets #16044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
HAS_SESSION_TICKETS
undefined inlib/vtls/mbedtls.c
).MBEDTLS_USE_PSA_CRYPTO
but without TLS 1.3 support:Solutions
mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets
requires the conditionals that are already covered byHAS_SESSION_TICKETS
, see include/mbedtls/ssl.h (and the lines above).MBEDTLS_SSL_TLS1_3_SIGNAL_NEW_SESSION_TICKETS_ENABLED
always resolves to1
because it is only meant as a boolean parameter for the function.When Mbed TLS is built with PSA, it must always be initialized regardless of the TLS 1.3 support.