-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Fix build with mbedtls v3.6 PSA but without TLS 1.3 or session tickets #16044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah, can you just rebase this again and force-push? I believe my symbol fix in the mean time made it conflict a little. |
86fd6dd to
656fed0
Compare
Done and also fancier now with less commits. ^^ |
…equires Mbed TLS >= v3.6.1
|
Thanks! |
|
Related blog post, since @misch7 also happened to become curl commit author number 1337 |
|
Thank you @bagder ! I feel honoured and I also want take the opportunity to thank you for |
Problems
HAS_SESSION_TICKETSundefined inlib/vtls/mbedtls.c).MBEDTLS_USE_PSA_CRYPTObut without TLS 1.3 support:Solutions
mbedtls_ssl_conf_tls13_enable_signal_new_session_ticketsrequires the conditionals that are already covered byHAS_SESSION_TICKETS, see include/mbedtls/ssl.h (and the lines above).MBEDTLS_SSL_TLS1_3_SIGNAL_NEW_SESSION_TICKETS_ENABLEDalways resolves to1because it is only meant as a boolean parameter for the function.When Mbed TLS is built with PSA, it must always be initialized regardless of the TLS 1.3 support.