cmake: prefer dash-style MSVC options #16063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
|
Analysis of PR #16063 at ae4d72d1: Test http/test_19_shutdown.py::TestShutdown::test_19_02_check_shutdown[h2] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1450 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1452 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
They play better with Unixy shells. The compiler has been supporting dash options since its early versions. Also fix to detect warnings options passed in dash-style. Closes curl#16063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They play better with Unixy shells. The compiler has been supporting
dash options since its early versions.
Also fix to detect warnings options passed in dash-style.