Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: prefer dash-style MSVC options #16063

Closed
wants to merge 2 commits into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 21, 2025

They play better with Unixy shells. The compiler has been supporting
dash options since its early versions.

Also fix to detect warnings options passed in dash-style.

@github-actions github-actions bot added the CI Continuous Integration label Jan 21, 2025
@vszakats vszakats changed the title msvc: prefer dash-style options cmake: prefer dash-style MSVC options Jan 21, 2025
@vszakats vszakats added cmake Windows Windows-specific labels Jan 21, 2025
@testclutch
Copy link

Analysis of PR #16063 at ae4d72d1:

Test http/test_19_shutdown.py::TestShutdown::test_19_02_check_shutdown[h2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1450 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1452 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@vszakats vszakats closed this in 8dfd271 Jan 22, 2025
@vszakats vszakats deleted the msvc-dash branch January 22, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Continuous Integration cmake tidy-up Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants